[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 2 Feb 2020 19:12:13 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...ux-mips.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
cc: Ralf Baechle <ralf@...ux-mips.org>,
"David S. Miller" <davem@...emloft.net>,
Andrew Morton <akpm@...ux-foundation.org>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device_id'
structure
On Sun, 2 Feb 2020, Christophe JAILLET wrote:
> 'struct eisa_device_id' must be ended by an empty string, not a NULL
> pointer. Otherwise, a NULL pointer dereference may occur in
> 'eisa_bus_match()'.
Umm, that's weird code there in `eisa_bus_match' (I do hope at least GCC
optimises the `strlen' away nowadays and checks for the character pointed
being null instead), but as usually with old stuff let's keep changes to
the minimum. So:
Acked-by: Maciej W. Rozycki <macro@...ux-mips.org>
Thanks for the fix!
Maciej
Powered by blists - more mailing lists