linux-kernel - Re: [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200203095553.GN1778@kadam>
Date:   Mon, 3 Feb 2020 12:55:53 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     macro@...ux-mips.org, ralf@...ux-mips.org, davem@...emloft.net,
        akpm@...ux-foundation.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] defxx: Fix a sentinel at the end of a 'eisa_device_id'
 structure

On Sun, Feb 02, 2020 at 03:23:41PM +0100, Christophe JAILLET wrote:
> 'struct eisa_device_id' must be ended by an empty string, not a NULL
> pointer. Otherwise, a NULL pointer dereference may occur in
> 'eisa_bus_match()'.
> 
> Also convert some spaces to tab to please 'checkpatch.pl'.
> 
> Fixes: e89a2cfb7d7b ("[TC] defxx: TURBOchannel support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/fddi/defxx.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/fddi/defxx.c b/drivers/net/fddi/defxx.c
> index 077c68498f04..7ef0c57f07c6 100644
> --- a/drivers/net/fddi/defxx.c
> +++ b/drivers/net/fddi/defxx.c
> @@ -3768,11 +3768,11 @@ static void dfx_pci_unregister(struct pci_dev *pdev)
>  
>  #ifdef CONFIG_EISA
>  static const struct eisa_device_id dfx_eisa_table[] = {
> -        { "DEC3001", DEFEA_PROD_ID_1 },
> -        { "DEC3002", DEFEA_PROD_ID_2 },
> -        { "DEC3003", DEFEA_PROD_ID_3 },
> -        { "DEC3004", DEFEA_PROD_ID_4 },
> -        { }
> +	{ "DEC3001", DEFEA_PROD_ID_1 },
> +	{ "DEC3002", DEFEA_PROD_ID_2 },
> +	{ "DEC3003", DEFEA_PROD_ID_3 },
> +	{ "DEC3004", DEFEA_PROD_ID_4 },
> +	{ "" }

You haven't changed runtime at all.  :P (struct eisa_device_id)->sig[]
is an array, not a pointer.  There is no NULL dereference because an
array in the middle of another array can't be NULL.

regards,
dan carpenter