[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200203233217.GB311651@builder>
Date: Mon, 3 Feb 2020 15:32:17 -0800
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Douglas Anderson <dianders@...omium.org>
Cc: Andrzej Hajda <a.hajda@...sung.com>,
Neil Armstrong <narmstrong@...libre.com>,
robdclark@...omium.org, linux-arm-msm@...r.kernel.org,
seanpaul@...omium.org, Jeffrey Hugo <jeffrey.l.hugo@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Clark <robdclark@...il.com>,
Jonas Karlman <jonas@...boo.se>, linux-kernel@...r.kernel.org,
dri-devel@...ts.freedesktop.org, David Airlie <airlied@...ux.ie>,
Jernej Skrabec <jernej.skrabec@...l.net>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH v3 2/9] drm/bridge: ti-sn65dsi86: zero is never greater
than an unsigned int
On Wed 18 Dec 14:35 PST 2019, Douglas Anderson wrote:
> When we iterate over ti_sn_bridge_dp_rate_lut, there's no reason to
> start at index 0 which always contains the value 0. 0 is not a valid
> link rate.
>
> This change should have no real effect but is a small cleanup.
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> Tested-by: Rob Clark <robdclark@...il.com>
> Reviewed-by: Rob Clark <robdclark@...il.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index 2fb9370a76e6..7b596af265e4 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -458,7 +458,7 @@ static void ti_sn_bridge_set_dp_rate(struct ti_sn_bridge *pdata)
> /* set DP data rate */
> dp_rate_mhz = ((bit_rate_mhz / pdata->dsi->lanes) * DP_CLK_FUDGE_NUM) /
> DP_CLK_FUDGE_DEN;
> - for (i = 0; i < ARRAY_SIZE(ti_sn_bridge_dp_rate_lut) - 1; i++)
> + for (i = 1; i < ARRAY_SIZE(ti_sn_bridge_dp_rate_lut) - 1; i++)
> if (ti_sn_bridge_dp_rate_lut[i] > dp_rate_mhz)
> break;
>
> --
> 2.24.1.735.g03f4e72817-goog
>
Powered by blists - more mailing lists