linux-kernel - Re: [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200204142718.GA23972@pauld.bos.csb>
Date:   Tue, 4 Feb 2020 09:27:19 -0500
From:   Phil Auld <pauld@...hat.com>
To:     Scott Wood <swood@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/core: sched_tick_remote: Remove duplicate
 assignment

Hi Scott,

On Mon, Feb 03, 2020 at 07:35:58PM -0500 Scott Wood wrote:
> A redundant "curr = rq->curr" was added; remove it.
> 
> Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
> Signed-off-by: Scott Wood <swood@...hat.com>
> ---
>  kernel/sched/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 45f79bcc3146..377ec26e9159 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
>  	if (cpu_is_offline(cpu))
>  		goto out_unlock;
>  
> -	curr = rq->curr;
>  	update_rq_clock(rq);
>  
>  	if (!is_idle_task(curr)) {
> -- 
> 1.8.3.1
> 

Reviewed-by: Phil Auld <pauld@...hat.com>

Out of curiosity, why remove this one and not the one right before the 
cpu_is_offline check?


Cheers,
Phil

--