linux-kernel - Re: [Freedreno] [v1] dt-bindings: msm:disp: update dsi and dpu bindings

Open Source and information security mailing list archives

Message-ID: <CAOCk7NoAY7QaoBufG=JOR54PocdtrMsxUh9HmdWEwQ4zSG5MDg@mail.gmail.com>
Date:   Tue, 4 Feb 2020 07:44:14 -0700
From:   Jeffrey Hugo <jeffrey.l.hugo@...il.com>
To:     Harigovindan P <harigovi@...eaurora.org>
Cc:     "open list:DRM PANEL DRIVERS" <dri-devel@...ts.freedesktop.org>,
        MSM <linux-arm-msm@...r.kernel.org>,
        freedreno <freedreno@...ts.freedesktop.org>,
        DTML <devicetree@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Rob Clark <robdclark@...il.com>, nganji@...eaurora.org,
        Sean Paul <seanpaul@...omium.org>, kalyan_t@...eaurora.org,
        "Kristian H. Kristensen" <hoegsberg@...omium.org>
Subject: Re: [Freedreno] [v1] dt-bindings: msm:disp: update dsi and dpu bindings

On Tue, Feb 4, 2020 at 7:15 AM Harigovindan P <harigovi@...eaurora.org> wrote:
>
> Updating bindings of dsi and dpu by adding and removing certain
> properties.
>
> Signed-off-by: Harigovindan P <harigovi@...eaurora.org>
> ---
>
> Changes in v1:
>         - Adding "ahb" clock as a required property.
>         - Adding "bus", "rot", "lut" as optional properties for sc7180 device.
>         - Removing properties from dsi bindings that are unused.
>         - Removing power-domain property since DSI is the child node of MDSS
>           and it will inherit supply from its parent.
>
>  Documentation/devicetree/bindings/display/msm/dpu.txt | 7 +++++++
>  Documentation/devicetree/bindings/display/msm/dsi.txt | 5 -----
>  2 files changed, 7 insertions(+), 5 deletions(-)
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt
> index af95586..61d659a 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi.txt
> +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt
> @@ -8,13 +8,10 @@ Required properties:
>  - reg-names: The names of register regions. The following regions are required:
>    * "dsi_ctrl"
>  - interrupts: The interrupt signal from the DSI block.
> -- power-domains: Should be <&mmcc MDSS_GDSC>.
>  - clocks: Phandles to device clocks.
>  - clock-names: the following clocks are required:
> -  * "mdp_core"
>    * "iface"
>    * "bus"
> -  * "core_mmss"

Why do you think these are unused?  I see them used in the driver, and
as far as I can tell these get routed to the hardware, therefore they
should be described in DT.

>    * "byte"
>    * "pixel"
>    * "core"
> @@ -156,7 +153,6 @@ Example:
>                         "core",
>                         "core_mmss",
>                         "iface",
> -                       "mdp_core",
>                         "pixel";
>                 clocks =
>                         <&mmcc MDSS_AXI_CLK>,
> @@ -164,7 +160,6 @@ Example:
>                         <&mmcc MDSS_ESC0_CLK>,
>                         <&mmcc MMSS_MISC_AHB_CLK>,
>                         <&mmcc MDSS_AHB_CLK>,
> -                       <&mmcc MDSS_MDP_CLK>,
>                         <&mmcc MDSS_PCLK0_CLK>;
>
>                 assigned-clocks =
> --
> 2.7.4
>
> _______________________________________________
> Freedreno mailing list
> Freedreno@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives