linux-kernel - Re: [PATCH 1/2] staging: octeon: delete driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200204225332.GC1128093@kroah.com>
Date:   Tue, 4 Feb 2020 22:53:32 +0000
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "brandonbonaby94@...il.com" <brandonbonaby94@...il.com>,
        "julia.lawall@...6.fr" <julia.lawall@...6.fr>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "paulburton@...nel.org" <paulburton@...nel.org>,
        "aaro.koskinen@....fi" <aaro.koskinen@....fi>,
        "fw@...len.de" <fw@...len.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ddaney@...iumnetworks.com" <ddaney@...iumnetworks.com>,
        "bobdc9664@...nam.cz" <bobdc9664@...nam.cz>,
        "sandro@...ery.com" <sandro@...ery.com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "ivalery111@...il.com" <ivalery111@...il.com>,
        "ynezz@...e.cz" <ynezz@...e.cz>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "wambui.karugax@...il.com" <wambui.karugax@...il.com>
Subject: Re: [PATCH 1/2] staging: octeon: delete driver

On Tue, Feb 04, 2020 at 12:31:16PM -0800, Matthew Wilcox wrote:
> On Tue, Feb 04, 2020 at 08:06:14PM +0000, Chris Packham wrote:
> > On Tue, 2020-02-04 at 07:09 +0000, gregkh@...uxfoundation.org wrote:
> > > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote:
> > > > I'll pipe up on this thread too
> > > > 
> > > > On Tue, 2019-12-10 at 02:42 -0800, Guenter Roeck wrote:
> > > > > On 12/10/19 1:15 AM, Greg Kroah-Hartman wrote:
> > > > > > This driver has been in the tree since 2009 with no real movement to get
> > > > > > it out.  Now it is starting to cause build issues and other problems for
> > > > > > people who want to fix coding style problems, but can not actually build
> > > > > > it.
> > > > > > 
> > > > > > As nothing is happening here, just delete the module entirely.
> > > > > > 
> > > > > > Reported-by: Guenter Roeck <linux@...ck-us.net>
> > > > > > Cc: David Daney <ddaney@...iumnetworks.com>
> > > > > > Cc: "David S. Miller" <davem@...emloft.net>
> > > > > > Cc: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> > > > > > Cc: Guenter Roeck <linux@...ck-us.net>
> > > > > > Cc: YueHaibing <yuehaibing@...wei.com>
> > > > > > Cc: Aaro Koskinen <aaro.koskinen@....fi>
> > > > > > Cc: Wambui Karuga <wambui.karugax@...il.com>
> > > > > > Cc: Julia Lawall <julia.lawall@...6.fr>
> > > > > > Cc: Florian Westphal <fw@...len.de>
> > > > > > Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> > > > > > Cc: Branden Bonaby <brandonbonaby94@...il.com>
> > > > > > Cc: "Petr Štetiar" <ynezz@...e.cz>
> > > > > > Cc: Sandro Volery <sandro@...ery.com>
> > > > > > Cc: Paul Burton <paulburton@...nel.org>
> > > > > > Cc: Dan Carpenter <dan.carpenter@...cle.com>
> > > > > > Cc: Giovanni Gherdovich <bobdc9664@...nam.cz>
> > > > > > Cc: Valery Ivanov <ivalery111@...il.com>
> > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > > > 
> > > > > Acked-by: Guenter Roeck <linux@...ck-us.net>
> > > > 
> > > > Please can we keep this driver. We do have platforms using it and we
> > > > would like it to stay around.
> > > > 
> > > > Clearly we'll need to sort things out to a point where they build
> > > > successfully. We've been hoping to see this move out of staging ever
> > > > since we selected Cavium as a vendor.
> > > 
> > > Great, can you send me a patchset that reverts this and fixes the build
> > > issues and accept maintainership of the code?
> > > 
> > 
> > Yep will do.
> > 
> > On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote:
> > > My advice is to delete all the COMPILE_TEST code.  That stuff was a
> > > constant source of confusion and headaches.
> > 
> > I was also going to suggest this. Since the COMPILE_TEST has been a
> > source of trouble I was going to propose dropping the || COMPILE_TEST
> > from the Kconfig for the octeon drivers.
> 
> Not having it also causes problems.  I didn't originally add it for
> shits and giggles.

Yes, without this option, the code bit-rotted horribly.  It needs to be
able to be built otherwise people will change the code and it will break
and no one will notice except Guenter's build bots and then no one will
fix it :(

i.e. exactly what was happening before...

So this needs to all be fixed up properly, and really, should be merged
to the "real" part of the kernel...

thanks,

greg k-h