linux-kernel - Re: [PATCH 1/2] staging: octeon: delete driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200205033416.GT1778@kadam>
Date:   Wed, 5 Feb 2020 06:34:16 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "brandonbonaby94@...il.com" <brandonbonaby94@...il.com>,
        "julia.lawall@...6.fr" <julia.lawall@...6.fr>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "paulburton@...nel.org" <paulburton@...nel.org>,
        "aaro.koskinen@....fi" <aaro.koskinen@....fi>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "fw@...len.de" <fw@...len.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ddaney@...iumnetworks.com" <ddaney@...iumnetworks.com>,
        "bobdc9664@...nam.cz" <bobdc9664@...nam.cz>,
        "sandro@...ery.com" <sandro@...ery.com>,
        "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "ivalery111@...il.com" <ivalery111@...il.com>,
        "ynezz@...e.cz" <ynezz@...e.cz>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "wambui.karugax@...il.com" <wambui.karugax@...il.com>
Subject: Re: [PATCH 1/2] staging: octeon: delete driver

On Tue, Feb 04, 2020 at 12:31:16PM -0800, Matthew Wilcox wrote:
> On Tue, Feb 04, 2020 at 08:06:14PM +0000, Chris Packham wrote:
> > On Tue, 2020-02-04 at 07:09 +0000, gregkh@...uxfoundation.org wrote:
> > > On Tue, Feb 04, 2020 at 04:02:15AM +0000, Chris Packham wrote:
> > On Tue, 2020-02-04 at 10:21 +0300, Dan Carpenter wrote:
> > > My advice is to delete all the COMPILE_TEST code.  That stuff was a
> > > constant source of confusion and headaches.
> > 
> > I was also going to suggest this. Since the COMPILE_TEST has been a
> > source of trouble I was going to propose dropping the || COMPILE_TEST
> > from the Kconfig for the octeon drivers.
> 
> Not having it also causes problems.  I didn't originally add it for
> shits and giggles.

I wonder if the kbuild bot does enough cross compile build testing these
days to detect compile problems.  It might have improved to the point
where COMPILE_TEST isn't required.

One of the things about having a bunch of dummy functions for
COMPILE_TEST is that they introduce a lot of static checker warnings.
The real function is supposed to initialize stuff but the dummy function
just returns so now we get uninitialized variable warnings etc.

regards,
dan carpenter