linux-kernel - Re: [v10 1/2] fs: New zonefs file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB5816A4CD15C760D0E5768285E7020@BYAPR04MB5816.namprd04.prod.outlook.com>
Date:   Wed, 5 Feb 2020 07:46:07 +0000
From:   Damien Le Moal <Damien.LeMoal@....com>
To:     Markus Elfring <Markus.Elfring@....de>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Darrick J. Wong" <darrick.wong@...cle.com>,
        Hannes Reinecke <hare@...e.de>,
        Johannes Thumshirn <jth@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Naohiro Aota <Naohiro.Aota@....com>
Subject: Re: [v10 1/2] fs: New zonefs file system

On 2020/02/05 16:17, Markus Elfring wrote:
>> Declaring it as
>>
>> static const char * const zgroups_name[] = { "cnv", "seq" };
>>
>> is probably what you are suggesting,
> 
> Yes.
> 
> 
>> but since the string literals are already constants by default,
>> I do not think there is any difference.
> 
> I propose to define this array also as a completely immutable data structure.

I understood that and pointed out that the added "const" does not change a
thing. I think that as is, it already is immutable. But sure, I can add
that const, no problem.

> 
> Regards,
> Markus
> 


-- 
Damien Le Moal
Western Digital Research