linux-kernel - Re: [PATCH v2] ASoC: wcd934x: Add missing COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200205113755.7daca1f1@canb.auug.org.au>
Date:   Wed, 5 Feb 2020 11:37:55 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        Lee Jones <lee.jones@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ASoC: wcd934x: Add missing COMMON_CLK dependency

Hi Geert,

On Tue, 4 Feb 2020 14:21:01 +0100 Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> On Tue, Feb 4, 2020 at 12:14 PM Srinivas Kandagatla
> <srinivas.kandagatla@...aro.org> wrote:
> > Looks like some platforms are not yet using COMMON CLK.
> >
> > PowerPC allyesconfig failed with below error in next
> >
> > ld: sound/soc/codecs/wcd934x.o:(.toc+0x0):
> >          undefined reference to `of_clk_src_simple_get'
> > ld: sound/soc/codecs/wcd934x.o: in function `.wcd934x_codec_probe':
> > wcd934x.c:(.text.wcd934x_codec_probe+0x3d4):
> >          undefined reference to `.__clk_get_name'
> > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x438):
> >          undefined reference to `.clk_hw_register'
> > ld: wcd934x.c:(.text.wcd934x_codec_probe+0x474):
> >          undefined reference to `.of_clk_add_provider'
> >
> > Add the missing COMMON_CLK dependency to fix this errors.
> >
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>  
> 
> Thanks for your patch!
> 
> But did this change really fix your PowerPC allyesconfig build?

It does not :-(

> SND_SOC_ALL_CODECS will still select it...
> 
> Fix sent.

I have applied that patch to linux-next today.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped