linux-kernel - Re: [PATCH] ASoC: wcd934x: Add missing COMMON_CLK dependency to SND_SOC_ALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200205113930.5eb08bb4@canb.auug.org.au>
Date:   Wed, 5 Feb 2020 11:39:30 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: wcd934x: Add missing COMMON_CLK dependency to
 SND_SOC_ALL_CODECS

Hi Geert,

On Tue,  4 Feb 2020 14:18:57 +0100 Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Just adding a dependency on COMMON_CLK to SND_SOC_WCD934X is not
> sufficient, as enabling SND_SOC_ALL_CODECS will still select it,
> breaking the build later:
> 
>     WARNING: unmet direct dependencies detected for SND_SOC_WCD934X
>       Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMMON_CLK [=n] && MFD_WCD934X [=m]
>       Selected by [m]:
>       - SND_SOC_ALL_CODECS [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && COMPILE_TEST [=y] && MFD_WCD934X [=m]
>     ...
>     ERROR: "of_clk_add_provider" [sound/soc/codecs/snd-soc-wcd934x.ko] undefined!
>     ERROR: "of_clk_src_simple_get" [sound/soc/codecs/snd-soc-wcd934x.ko] undefined!
>     ERROR: "clk_hw_register" [sound/soc/codecs/snd-soc-wcd934x.ko] undefined!
>     ERROR: "__clk_get_name" [sound/soc/codecs/snd-soc-wcd934x.ko] undefined!
> 
> Fix this by adding the missing dependency to SND_SOC_ALL_CODECS
> 
> Fixes: 42b716359beca106 ("ASoC: wcd934x: Add missing COMMON_CLK dependency")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> Seen with e.g. m68k/allmodconfig.

Also seen with powerpc/allyesconfig

Tested-by: Stephen Rothwell <sfr@...b.auug.org.au>

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped