linux-kernel - [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200205152429.ejgx2on2z4hoycus@kili.mountain>
Date:   Wed, 5 Feb 2020 18:24:29 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Joe Perches <joe@...ches.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b

The get_maintainer.pl script looks at git history to create the CC list,
but unfortunately sometimes those email addresses are out of date.  The
script also looks at the MAINTAINERS file, of course, but if it already
found an email address for a maintainer in the git history then the
deduplicate_email() function will remove the second address.

It should save the MAINTAINERS address first, before loading the commit
signer addresses.

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
---
We will have to add a special case if the Dan Williamses ever decide
to work on the same subsystem.

 scripts/get_maintainer.pl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 34085d146fa2..e5bdd3143a49 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -932,14 +932,14 @@ sub get_maintainers {
 	}
     }
 
-    foreach my $fix (@fixes) {
-	vcs_add_commit_signers($fix, "blamed_fixes");
-    }
-
     foreach my $email (@email_to, @list_to) {
 	$email->[0] = deduplicate_email($email->[0]);
     }
 
+    foreach my $fix (@fixes) {
+	vcs_add_commit_signers($fix, "blamed_fixes");
+    }
+
     foreach my $file (@files) {
 	if ($email &&
 	    ($email_git || ($email_git_fallback &&
-- 
2.11.0