linux-kernel - Re: [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76267eda365d7c5c0adc7dd16681973c5378df8e.camel@perches.com>
Date:   Wed, 05 Feb 2020 10:46:32 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Douglas Anderson <dianders@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] get_maintainer: Prefer MAINTAINER address over S-o-b

On Wed, 2020-02-05 at 18:24 +0300, Dan Carpenter wrote:
> The get_maintainer.pl script looks at git history to create the CC list,
> but unfortunately sometimes those email addresses are out of date.  The
> script also looks at the MAINTAINERS file, of course, but if it already
> found an email address for a maintainer in the git history then the
> deduplicate_email() function will remove the second address.
> 
> It should save the MAINTAINERS address first, before loading the commit
> signer addresses.

Yeah, thanks.  This has been submitted already.
https://lore.kernel.org/patchwork/patch/1186249/

> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> ---
> We will have to add a special case if the Dan Williamses ever decide
> to work on the same subsystem.
> 
>  scripts/get_maintainer.pl | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 34085d146fa2..e5bdd3143a49 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -932,14 +932,14 @@ sub get_maintainers {
>  	}
>      }
>  
> -    foreach my $fix (@fixes) {
> -	vcs_add_commit_signers($fix, "blamed_fixes");
> -    }
> -
>      foreach my $email (@email_to, @list_to) {
>  	$email->[0] = deduplicate_email($email->[0]);
>      }
>  
> +    foreach my $fix (@fixes) {
> +	vcs_add_commit_signers($fix, "blamed_fixes");
> +    }
> +
>      foreach my $file (@files) {
>  	if ($email &&
>  	    ($email_git || ($email_git_fallback &&