linux-kernel - Re: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ftfo29zn.fsf@belgarion.home>
Date:   Wed, 05 Feb 2020 18:57:00 +0100
From:   Robert Jarzmik <robert.jarzmik@...e.fr>
To:     Lubomir Rintel <lkundrak@...sk>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there

Bartosz Golaszewski <bgolaszewski@...libre.com> writes:

> wt., 28 sty 2020 o 22:08 Lubomir Rintel <lkundrak@...sk> napisał(a):
>>
>> Not all platforms use those. Let's use
>> platform_get_irq_byname_optional() instead platform_get_irq_byname() so
>> that we avoid a useless warning:
>>
>>   [    1.359455] pxa-gpio d4019000.gpio: IRQ gpio0 not found
>>   [    1.359583] pxa-gpio d4019000.gpio: IRQ gpio1 not found
>>
>> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
Okay, what would have really be nice in the commit message was to state _which_
platform doesn't use these, and still use pxa-gpio as their gpio driver.

Cheers.

--
Robert

PS: And yes, my response is late, but I'm moving house so my ping is huge
lately.