linux-kernel - Re: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are not there

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMpxmJUPcackGYLfX83TT1V9x2=iHgnw3cZ=KufuHn9FeKOn_A@mail.gmail.com>
Date:   Tue, 4 Feb 2020 11:13:44 +0100
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Robert Jarzmik <robert.jarzmik@...e.fr>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: pxa: Avoid a warning when gpio0 and gpio1 IRQS are
 not there

wt., 28 sty 2020 o 22:08 Lubomir Rintel <lkundrak@...sk> napisał(a):
>
> Not all platforms use those. Let's use
> platform_get_irq_byname_optional() instead platform_get_irq_byname() so
> that we avoid a useless warning:
>
>   [    1.359455] pxa-gpio d4019000.gpio: IRQ gpio0 not found
>   [    1.359583] pxa-gpio d4019000.gpio: IRQ gpio1 not found
>
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>
> ---
>  drivers/gpio/gpio-pxa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
> index 9888b62f37afb..567742d962aef 100644
> --- a/drivers/gpio/gpio-pxa.c
> +++ b/drivers/gpio/gpio-pxa.c
> @@ -652,8 +652,8 @@ static int pxa_gpio_probe(struct platform_device *pdev)
>         if (!pchip->irqdomain)
>                 return -ENOMEM;
>
> -       irq0 = platform_get_irq_byname(pdev, "gpio0");
> -       irq1 = platform_get_irq_byname(pdev, "gpio1");
> +       irq0 = platform_get_irq_byname_optional(pdev, "gpio0");
> +       irq1 = platform_get_irq_byname_optional(pdev, "gpio1");
>         irq_mux = platform_get_irq_byname(pdev, "gpio_mux");
>         if ((irq0 > 0 && irq1 <= 0) || (irq0 <= 0 && irq1 > 0)
>                 || (irq_mux <= 0))
> --
> 2.24.1
>

Patch applied. Thanks!

Bartosz