linux-kernel - Re: [PATCH] of: clk: Make <linux/of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200205225145.5486220730@mail.kernel.org>
Date:   Wed, 05 Feb 2020 14:51:44 -0800
From:   Stephen Boyd <sboyd@...nel.org>
To:     Frank Rowand <frowand.list@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>
Subject: Re: [PATCH] of: clk: Make <linux/of_clk.h> self-contained

Quoting Geert Uytterhoeven (2020-02-05 11:46:49)
> Depending on include order:
> 
>     include/linux/of_clk.h:11:45: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
>      unsigned int of_clk_get_parent_count(struct device_node *np);
>                                                  ^~~~~~~~~~~
>     include/linux/of_clk.h:12:43: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
>      const char *of_clk_get_parent_name(struct device_node *np, int index);
>                                                ^~~~~~~~~~~
>     include/linux/of_clk.h:13:31: warning: \u2018struct of_device_id\u2019 declared inside parameter list will not be visible outside of this definition or declaration
>      void of_clk_init(const struct of_device_id *matches);
>                                    ^~~~~~~~~~~~
> 
> Fix this by adding forward declarations for struct device_node and
> struct of_device_id.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> Noticed when cleaning up some platform code.
> I am not aware of this being triggered in upstream, but this will become a
> dependency for these cleanups.

So apply for fixes? I'll just throw it in now.

Applied to clk-next.