linux-kernel - Re: [PATCH] of: clk: Make <linux/of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXLFq+Ebtmfsw45=08U7X5Fv9ZvsHO=q-PcNON51HjqaQ@mail.gmail.com>
Date:   Thu, 6 Feb 2020 09:06:53 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Frank Rowand <frowand.list@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] of: clk: Make <linux/of_clk.h> self-contained

Hi Stephen,

On Wed, Feb 5, 2020 at 11:51 PM Stephen Boyd <sboyd@...nel.org> wrote:
> Quoting Geert Uytterhoeven (2020-02-05 11:46:49)
> > Depending on include order:
> >
> >     include/linux/of_clk.h:11:45: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> >      unsigned int of_clk_get_parent_count(struct device_node *np);
> >                                                  ^~~~~~~~~~~
> >     include/linux/of_clk.h:12:43: warning: \u2018struct device_node\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> >      const char *of_clk_get_parent_name(struct device_node *np, int index);
> >                                                ^~~~~~~~~~~
> >     include/linux/of_clk.h:13:31: warning: \u2018struct of_device_id\u2019 declared inside parameter list will not be visible outside of this definition or declaration
> >      void of_clk_init(const struct of_device_id *matches);
> >                                    ^~~~~~~~~~~~
> >
> > Fix this by adding forward declarations for struct device_node and
> > struct of_device_id.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > ---
> > Noticed when cleaning up some platform code.
> > I am not aware of this being triggered in upstream, but this will become a
> > dependency for these cleanups.
>
> So apply for fixes? I'll just throw it in now.

Yep.

> Applied to clk-next.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds