lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Feb 2020 17:56:06 +0100 From: Greg KH <gregkh@...uxfoundation.org> To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org> Cc: arnd@...db.de, smohanad@...eaurora.org, jhugo@...eaurora.org, kvalo@...eaurora.org, bjorn.andersson@...aro.org, hemantk@...eaurora.org, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 02/16] bus: mhi: core: Add support for registering MHI controllers On Fri, Jan 31, 2020 at 07:19:55PM +0530, Manivannan Sadhasivam wrote: > +static void mhi_release_device(struct device *dev) > +{ > + struct mhi_device *mhi_dev = to_mhi_device(dev); > + > + if (mhi_dev->ul_chan) > + mhi_dev->ul_chan->mhi_dev = NULL; That looks really odd. Why didn't you just drop the reference you should have grabbed here for this pointer? You did properly increment it when you saved it, right? :) > + > + if (mhi_dev->dl_chan) > + mhi_dev->dl_chan->mhi_dev = NULL; Same here. thanks, greg k-h
Powered by blists - more mailing lists