linux-kernel - Re: [PATCH 06/28] ata: use COMMAND_LINE_SIZE for ata_force_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3cfa8b05-2ffa-b12f-92a6-7554fcb1297e@samsung.com>
Date:   Fri, 7 Feb 2020 15:17:31 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Michael Schmitz <schmitzmic@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/28] ata: use COMMAND_LINE_SIZE for
 ata_force_param_buf[] size


On 1/29/20 6:18 PM, Christoph Hellwig wrote:
> On Tue, Jan 28, 2020 at 02:33:21PM +0100, Bartlomiej Zolnierkiewicz wrote:
>> Use COMMAND_LINE_SIZE instead PAGE_SIZE for ata_force_param_buf[]
>> size as libata parameters buffer doesn't need to be bigger than
>> the command line buffer.
>>
>> For many architectures this results in decreased libata-core.o
>> size (COMMAND_LINE_SIZE varies from 256 to 4096 while the minimum
>> PAGE_SIZE is 4096).
>>
>> Code size savings on m68k arch using atari_defconfig:
>>
>>    text    data     bss     dec     hex filename
>> before:
>>   41064    4413      40   45517    b1cd drivers/ata/libata-core.o
>> after:
>>   41064     573      40   41677    a2cd drivers/ata/libata-core.o
>>
>> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> 
> This looks like a good start, so:
> 
> Reviewed-by: Christoph Hellwig <hch@....de>

Thanks.

> But evne COMMAND_LINE_SIZE is quite a lot of overhead.  Can we maybe add
> a new Kconfig option to optionally disable the libata.force= entirely?

I've added patch making "libata.force=" optional in v2
(disabling "libata.force=" saves us additional 3kB).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics