linux-kernel - Re: [PATCH v2] io_uring: add cleanup for openat()/statx()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66ab5ebd-8a9c-47bc-1bf2-8a328e70c290@gmail.com>
Date:   Sat, 8 Feb 2020 00:18:48 +0300
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Jens Axboe <axboe@...nel.dk>, io-uring@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] io_uring: add cleanup for openat()/statx()

On 08/02/2020 00:13, Jens Axboe wrote:
> On 2/7/20 1:59 PM, Pavel Begunkov wrote:
>> openat() and statx() may have allocated ->open.filename, which should be
>> be put. Add cleanup handlers for them.
> 
> Thanks, applied - but I dropped this hunk:

That's the second time it slipped, I need to read patches more attentively.
Thanks

> 
>> @@ -2857,7 +2862,6 @@ static void io_close_finish(struct io_wq_work **workptr)
>>  	}
>>  
>>  	fput(req->close.put_file);
>> -
>>  	io_put_req_find_next(req, &nxt);
>>  	if (nxt)
>>  		io_wq_assign_next(workptr, nxt);
> 

-- 
Pavel Begunkov



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)