linux-kernel - Re: [PATCH 1/3] media: vimc: Support multiple buscodes for each pixelformat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200208203639.nxxzgh6j6z7yagzc@ArchWay.local>
Date:   Sat, 08 Feb 2020 20:36:50 +0000
From:   Nícolas F. R. A. Prado 
        <nfraprado@...tonmail.com>
To:     Helen Koike <helen.koike@...labora.com>
Cc:     linux-media@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hverkuil@...all.nl>,
        linux-kernel@...r.kernel.org, lkcamp@...ts.libreplanetbr.org
Subject: Re: [PATCH 1/3] media: vimc: Support multiple buscodes for each pixelformat

Hi Helen,
thanks for the review.

Just one comment below.

On Wed, Feb 05, 2020 at 11:17:31AM -0300, Helen Koike wrote:
>
> Hi Nícolas,
>
> Thanks for the patch, just some minor nits:
>
> On 2/2/20 1:50 PM, Nícolas F. R. A. Prado wrote:
> > diff --git a/drivers/media/platform/vimc/vimc-common.h b/drivers/media/platform/vimc/vimc-common.h
> > index 87eb8259c2a8..132a5889f1ea 100644
> > --- a/drivers/media/platform/vimc/vimc-common.h
> > +++ b/drivers/media/platform/vimc/vimc-common.h
> > @@ -69,7 +69,7 @@ do {                                                                      \
> >   * V4L2_PIX_FMT_* fourcc pixelformat and its bytes per pixel (bpp)
> >   */
> >  struct vimc_pix_map {
> > -   unsigned int code;
> > +   unsigned int code[3];
>
> why 3?

On my patch I'm using at most 2.
I chose 3 so that it would be easier to add more formats, but I guess it doesn't
really make sense, since it's wasting memory and that value can be increased
when it's necessary.
So I should change it to 2, right?

> Regards,
> Helen

Thanks,
Nícolas