lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 09 Feb 2020 14:00:16 +0000 From: Nícolas F. R. A. Prado <nfraprado@...tonmail.com> To: Helen Koike <helen.koike@...labora.com> Cc: linux-media@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, Hans Verkuil <hverkuil@...all.nl>, linux-kernel@...r.kernel.org, lkcamp@...ts.libreplanetbr.org Subject: Re: [PATCH 2/3] media: vimc: Add GBR media bus code Hi Helen, thank you for the review. Please see my comment below. On Wed, Feb 05, 2020 at 11:17:35AM -0300, Helen Koike wrote: > > Hi Nícolas, > > Thank you for the patch. > > On 2/2/20 1:50 PM, Nícolas F. R. A. Prado wrote: > > Add missing GBR888_1X24 media bus code in the vimc_pix_map_list. Since > > there is no pixel format for it, use the pixelformat for RGB. > > > > Co-developed-by: Vitor Massaru Iha <vitor@...saru.org> > > Signed-off-by: Vitor Massaru Iha <vitor@...saru.org> > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...tonmail.com> > > --- > > drivers/media/platform/vimc/vimc-common.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/vimc/vimc-common.c b/drivers/media/platform/vimc/vimc-common.c > > index 55797e5ab2b1..591a50f63766 100644 > > --- a/drivers/media/platform/vimc/vimc-common.c > > +++ b/drivers/media/platform/vimc/vimc-common.c > > @@ -25,7 +25,7 @@ static const struct vimc_pix_map vimc_pix_map_list[] = { > > .bayer = false, > > }, > > { > > - .code = {MEDIA_BUS_FMT_RGB888_1X24}, > > + .code = {MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_GBR888_1X24}, > > Could you add spaces around the curly brackets here too? > > I was also thinking that all the MEDIA_BUS_FMT_RGB888_* and MEDIA_BUS_FMT_GBR888_* variants > could be added here (to be verified). Now that you said it, it does seem that this could be done. >From the pixelformat definitions on [1], there is a single format definition for RGB-8-8-8 and for BGR-8-8-8: #define V4L2_PIX_FMT_BGR24 v4l2_fourcc('B', 'G', 'R', '3') /* 24 BGR-8-8-8 */ #define V4L2_PIX_FMT_RGB24 v4l2_fourcc('R', 'G', 'B', '3') /* 24 RGB-8-8-8 */ This probably means that all media bus code variants of RGB888 should map to the same RGB888 pixelformat. Same for BGR888. So, should I go on and send a v2 adding these other formats or should we wait for others to comment on this first? Thanks, Nícolas [1] https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/videodev2.h#L549 > > Thanks > Helen > > > .pixelformat = V4L2_PIX_FMT_RGB24, > > .bpp = 3, > > .bayer = false, > >
Powered by blists - more mailing lists