linux-kernel - RE: [PATCH 1/2 V2] mfd: constify properties in mfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29e51a81900f4009ab173058bdf9ebde@intel.com>
Date:   Sun, 9 Feb 2020 11:57:56 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Lee Jones <lee.jones@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2 V2] mfd: constify properties in mfd_cell


> 
> On Sat, Feb 8, 2020 at 8:44 PM Tomas Winkler <tomas.winkler@...el.com>
> wrote:
> >
> > Constify 'struct property_entry *properties' in mfd_cell It is always
> > passed around as a pointer const struct.
> 
> I guess this should be second patch in the split and it's actually dependent to the
> first one (won't we get a compiler warning when we drop const qualifier during
> assignment?).
> 
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > ---
> >
> > V2: drop platform_device part
> 
> Btw, when you prepare series, you may use -vX command line parameter,
> where X is a version number. The scripts will put v2 in each Subject line
> uniformly.
Right, just the second patch was a new one, so not sure I should mark it v2. 
Thanks
Tomas