linux-kernel - Re: [PATCH] checkpatch: Remove email address comment from email address comparisons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcd8b6f57578f6ec0250b68206f0930b4aa64864.camel@perches.com>
Date:   Mon, 10 Feb 2020 15:08:21 -0800
From:   Joe Perches <joe@...ches.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Andy Whitcroft <apw@...onical.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Remove email address comment from email
 address comparisons

On Mon, 2020-02-10 at 14:25 -0800, Andrew Morton wrote:
> On Mon, 10 Feb 2020 10:52:16 -0800 Joe Perches <joe@...ches.com> wrote:
> 
> > About 2% of the last 100K commits have email addresses that include an
> > RFC2822 compliant comment like:
> > 
> > 	Peter Zijlstra (Intel) <peterz@...radead.org>
> > 
> > checkpatch currently does a comparison of the complete name and address
> > to the submitted author to determine if the author has signed-off and
> > emits a warning if the exact email names and addresses do not match.
> 
> Yes, I've seen this a few times.
> 
> > Unfortunately, the author email address can be written without the comment
> > like:
> > 
> > 	Peter Zijlstra <peterz@...radead.org>
> > 
> > Add logic to compare the comment stripped email addresses to avoid this
> > warning.
> 
> Where "stripped" means "after removing stuff in parentheses"?

Basically, yes.

> Why do we consider the display name at all?  It's the
> "peterz@...radead.org" part which matters for comparison purposes?

True, but if people are going to author a patch with
one name and sign it with a different one, then some
warning should probably be emitted.

btw:

This code is case sensitive and probably should not be.

I'll probably send a new patch, but the generic use of
'fc' is not supported for older perl versions and so it'll
likely use 'lc' instead.