linux-kernel - Re: [PATCH v2 1/4] dt-bindings: regulator: Add document for MT6359 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8398188f-820a-5abf-f52e-b79c0c583704@gmail.com>
Date:   Tue, 11 Feb 2020 17:06:32 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Wen Su <Wen.Su@...iatek.com>, Mark Brown <broonie@...nel.org>
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        wsd_upstream@...iatek.com, linux-kernel@...r.kernel.org,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-mediatek@...ts.infradead.org,
        Lee Jones <lee.jones@...aro.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: regulator: Add document for MT6359
 regulator



On 10/02/2020 12:57, Wen Su wrote:
> Hi, 
> 
> On Thu, 2020-02-06 at 11:49 +0000, Mark Brown wrote:
>> On Thu, Feb 06, 2020 at 11:06:48AM +0800, Wen Su wrote:
>>
>>> +Required properties:
>>> +- compatible: "mediatek,mt6359-regulator"
>>
>> Why does this need a compatible string - it looks like it's just
>> encoding the way Linux splits devices up into the DT, not
>> providing some reusable IP block.
> 
> Thanks for your comments.
> I will remove it in the next patch.
> 

If this the way to go, then please fix all the other MediaTek binding
description for regulators (+ the dts) as this is then wrong.

Thanks!
Matthias