linux-kernel - Re: [PATCH v2 1/4] dt-bindings: regulator: Add document for MT6359 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1581487721.16783.9.camel@mtkswgap22>
Date:   Wed, 12 Feb 2020 14:08:41 +0800
From:   Wen Su <Wen.Su@...iatek.com>
To:     Mark Brown <broonie@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
CC:     Mark Rutland <mark.rutland@....com>, <devicetree@...r.kernel.org>,
        <wsd_upstream@...iatek.com>, <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        <linux-mediatek@...ts.infradead.org>,
        Lee Jones <lee.jones@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: regulator: Add document for MT6359
 regulator

Hi, 

On Tue, 2020-02-11 at 17:06 +0100, Matthias Brugger wrote:
> 
> On 10/02/2020 12:57, Wen Su wrote:
> > Hi, 
> > 
> > On Thu, 2020-02-06 at 11:49 +0000, Mark Brown wrote:
> >> On Thu, Feb 06, 2020 at 11:06:48AM +0800, Wen Su wrote:
> >>
> >>> +Required properties:
> >>> +- compatible: "mediatek,mt6359-regulator"
> >>
> >> Why does this need a compatible string - it looks like it's just
> >> encoding the way Linux splits devices up into the DT, not
> >> providing some reusable IP block.
> > 
> > Thanks for your comments.
> > I will remove it in the next patch.
> > 
> 
> If this the way to go, then please fix all the other MediaTek binding
> description for regulators (+ the dts) as this is then wrong.
> Thanks!
> Matthias

The mt6359-regulator driver is still a reusable IP block.It could be
adding more other MediaTek pmic mt6359 similar compatible device. But
currently this patch only testing on pmic mt6359.
Is it allowable to keep compatible string in binding description ?

Thanks