linux-kernel - Re: [GIT PULL] KVM changes for Linux 5.6-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 12:13:50 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        KVM list <kvm@...r.kernel.org>,
        Oliver Upton <oupton@...gle.com>
Subject: Re: [GIT PULL] KVM changes for Linux 5.6-rc2

On Wed, Feb 12, 2020 at 12:02 PM Paolo Bonzini <pbonzini@...hat.com> wrote:
>
> I know, but still I consider it.  There is no reason why the "build
> test" should be anything more than "make && echo yes i am build-tested".

It damn well should check for warnings.

And if you can't bother eye-balling it or scripting it, then simply use

   make KCFLAGS=-Werror

but sadly I can't enforce that in general for all kernel builds simply
because some people use compilers that cause new warnings (compiler
updates etc commonly result in them, for example).

So I can't add -Werror in general, but developers can certainly use it
trivially.

No grep or other scripting required (although the above may cause
problems for that one sample file that does cause warnings - I didn't
check).

              Linus