linux-kernel - Re: [PATCH] microblaze: Fix unistd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a1kjK=fqJiPWPOG19pBEX+khAgVyMC-7AqT4BiH8dDn8g@mail.gmail.com>
Date:   Wed, 12 Feb 2020 09:38:03 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michal Simek <monstr@...str.eu>, git@...inx.com,
        Firoz Khan <firoz.khan@...aro.org>,
        Stefan Asserhall <stefan.asserhall@...inx.com>
Subject: Re: [PATCH] microblaze: Fix unistd_32.h generation format

On Wed, Feb 12, 2020 at 8:56 AM Michal Simek <michal.simek@...inx.com> wrote:
>
> Generated files are also checked by sparse that's why add newline
> to remove sparse (C=1) warning:
> ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
> warning: no newline at end of file
>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> Reviewed-by: Stefan Asserhall <stefan.asserhall@...inx.com>

Acked-by: Arnd Bergmann <arnd@...db.de>

The patch looks good, but if you don't mind respinning it, could respin
it to do the same thing for all architectures at once? I see that  some
already have it, but most don't.

> ---
>
>  arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/microblaze/kernel/syscalls/syscallhdr.sh b/arch/microblaze/kernel/syscalls/syscallhdr.sh
> index 2e9062a926a3..4f4238433644 100644
> --- a/arch/microblaze/kernel/syscalls/syscallhdr.sh
> +++ b/arch/microblaze/kernel/syscalls/syscallhdr.sh
> @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
>         printf "#endif\n"
>         printf "\n"
>         printf "#endif /* %s */" "${fileguard}"
> +       printf "\n"
>  ) > "$out"
> --
> 2.25.0
>