linux-kernel - Re: [PATCH 15/18] xtensa: replace setup_irq() by request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMo8BfJU5Uz7uDcbX8QZX=16JJNKvaZvDoS1fqK1fsOaKQ-0mg@mail.gmail.com>
Date:   Wed, 12 Feb 2020 01:10:00 -0800
From:   Max Filippov <jcmvbkbc@...il.com>
To:     afzal mohammed <afzal.mohd.ma@...il.com>
Cc:     "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@...ux-xtensa.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Chris Zankel <chris@...kel.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sinan Kaya <okaya@...nel.org>
Subject: Re: [PATCH 15/18] xtensa: replace setup_irq() by request_irq()

On Wed, Feb 12, 2020 at 12:05 AM afzal mohammed <afzal.mohd.ma@...il.com> wrote:
>
> request_irq() is preferred over setup_irq(). Existing callers of
> setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while
> memory allocators are ready by 'mm_init()'.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> Seldom remove_irq() usage has been observed coupled with setup_irq(),
> wherever that has been found, it too has been replaced by free_irq().
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@...il.com>
> ---
>  arch/xtensa/kernel/smp.c  |  8 ++------
>  arch/xtensa/kernel/time.c | 10 +++-------
>  2 files changed, 5 insertions(+), 13 deletions(-)

Acked-by: Max Filippov <jcmvbkbc@...il.com>

-- 
Thanks.
-- Max