linux-kernel - Re: [PATCH v5 07/18] platform/x86: intel_scu_ipc: Add managed function to register SCU IPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 13:44:24 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Lee Jones <lee.jones@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Zha Qipeng <qipeng.zha@...el.com>,
        "David E . Box" <david.e.box@...ux.intel.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 07/18] platform/x86: intel_scu_ipc: Add managed
 function to register SCU IPC

On Tue, Feb 11, 2020 at 05:51:29PM +0200, Andy Shevchenko wrote:
> On Tue, Feb 11, 2020 at 04:25:52PM +0300, Mika Westerberg wrote:
> > Drivers such as intel_pmc_ipc.c can be unloaded as well so in order to
> > support those in this driver add a new function that can be called to
> > unregister the SCU IPC when it is not needed anymore.
> > 
> > We also add a managed version of the intel_scu_ipc_register() that takes
> > care of calling intel_scu_ipc_unregister() automatically when the driver
> > is unbound.
> 
> ...
> 
> > +	devres = devres_alloc(devm_intel_scu_ipc_unregister, sizeof(*devres),
> > +			      GFP_KERNEL);
> 
> Maybe devres -> dr and put on one line?
> But it's up to you, I'm fine with the current as well.

Sure, I'll change that.