linux-kernel - Re: [PATCH v3 2/2] arm64: tegra: add unit address to nodes under i2c-tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200213223329.7onm5k6elqhrn7ty@earth.universe>
Date:   Thu, 13 Feb 2020 23:33:29 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
Cc:     linux-i2c@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com, bleung@...omium.org,
        enric.balletbo@...labora.com, groeck@...omium.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        helen.koike@...labora.com, ezequiel@...labora.com,
        kernel@...labora.com, dafna3@...il.com
Subject: Re: [PATCH v3 2/2] arm64: tegra: add unit address to nodes under
 i2c-tunnel

Hi,

On Thu, Feb 13, 2020 at 10:46:56PM +0100, Dafna Hirschfeld wrote:
> add unit address to the nodes bq24735, smart-battery
> 
> This fixes the warning:
> 'bq24735', 'smart-battery' do not match any of the
> regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> ---

While fixing the node names, it makes sense to also
use device class instead of name as mentioned in
Documentation/devicetree/bindings/writing-bindings.txt

>  arch/arm64/boot/dts/nvidia/tegra132-norrin.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> index a0385a386a3f..a19171f6f0f7 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra132-norrin.dts
> @@ -767,7 +767,7 @@
>  
>  				google,remote-bus = <0>;
>  
> -				charger: bq24735 {
> +				charger: bq24735@9 {

charger: charger@9 {

>  					compatible = "ti,bq24735";
>  					reg = <0x9>;
>  					interrupt-parent = <&gpio>;
> @@ -778,7 +778,7 @@
>  							GPIO_ACTIVE_HIGH>;
>  				};
>  
> -				battery: smart-battery {
> +				battery: smart-battery@b {

battery: battery@b {

>  					compatible = "sbs,sbs-battery";
>  					reg = <0xb>;
>  					battery-name = "battery";

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)