linux-kernel - Re: [PATCH v3 1/2] dt-bindings: i2c: cros-ec-tunnel: convert i2c-cros-ec-tunnel.txt to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200213223535.j2ronp5jicxwa3mv@earth.universe>
Date:   Thu, 13 Feb 2020 23:35:35 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
Cc:     linux-i2c@...r.kernel.org, robh+dt@...nel.org,
        mark.rutland@....com, bleung@...omium.org,
        enric.balletbo@...labora.com, groeck@...omium.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        helen.koike@...labora.com, ezequiel@...labora.com,
        kernel@...labora.com, dafna3@...il.com
Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: cros-ec-tunnel: convert
 i2c-cros-ec-tunnel.txt to yaml

Hi,

On Thu, Feb 13, 2020 at 10:46:55PM +0100, Dafna Hirschfeld wrote:
> Convert the binding file i2c-cros-ec-tunnel.txt to yaml format.
> 
> This was tested and verified on ARM and ARM64 with:
> 
> make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-cros-ec-tunnel.yaml
> make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/i2c/i2c-cros-ec-tunnel.yaml
> 
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> ---

[...]

> +examples:
> +  - |
> +    cros-ec@0 {
> +        compatible = "google,cros-ec-spi";
> +        i2c-tunnel {
> +            compatible = "google,cros-ec-i2c-tunnel";
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +            google,remote-bus = <0>;
> +
> +            battery: sbs-battery@b {

This should be "battery@b {", since node names are supposed to
match the class of the device instead of the name of the device.

> +                compatible = "sbs,sbs-battery";
> +                reg = <0xb>;
> +                sbs,poll-retry-count = <1>;
> +            };
> +        };
> +    };

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)