lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 14 Feb 2020 10:00:09 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     linmiaohe <linmiaohe@...wei.com>, rkrcmar@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] KVM: nVMX: Fix some obsolete comments and grammar error

On 14/02/20 03:44, linmiaohe wrote:
> From: Miaohe Lin <linmiaohe@...wei.com>
> 
> Fix wrong variable names and grammar error in comment.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  arch/x86/kvm/vmx/nested.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
> index 657c2eda357c..f2d8cb68dce8 100644
> --- a/arch/x86/kvm/vmx/nested.c
> +++ b/arch/x86/kvm/vmx/nested.c
> @@ -3160,10 +3160,10 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu,
>   * or KVM_SET_NESTED_STATE).  Otherwise it's called from vmlaunch/vmresume.
>   *
>   * Returns:
> - *	NVMX_ENTRY_SUCCESS: Entered VMX non-root mode
> - *	NVMX_ENTRY_VMFAIL:  Consistency check VMFail
> - *	NVMX_ENTRY_VMEXIT:  Consistency check VMExit
> - *	NVMX_ENTRY_KVM_INTERNAL_ERROR: KVM internal error
> + *	NVMX_VMENTRY_SUCCESS: Entered VMX non-root mode
> + *	NVMX_VMENTRY_VMFAIL:  Consistency check VMFail
> + *	NVMX_VMENTRY_VMEXIT:  Consistency check VMExit
> + *	NVMX_VMENTRY_KVM_INTERNAL_ERROR: KVM internal error
>   */
>  enum nvmx_vmentry_status nested_vmx_enter_non_root_mode(struct kvm_vcpu *vcpu,
>  							bool from_vmentry)
> @@ -5301,7 +5301,7 @@ static bool nested_vmx_exit_handled_io(struct kvm_vcpu *vcpu,
>  }
>  
>  /*
> - * Return 1 if we should exit from L2 to L1 to handle an MSR access access,
> + * Return 1 if we should exit from L2 to L1 to handle an MSR access,
>   * rather than handle it ourselves in L0. I.e., check whether L1 expressed
>   * disinterest in the current event (read or write a specific MSR) by using an
>   * MSR bitmap. This may be the case even when L0 doesn't use MSR bitmaps.
> 

Queued, thanks.

Paolo

Powered by blists - more mailing lists