linux-kernel - Re: [PATCH] counter: stm32-timer-cnt: remove iio headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 14 Feb 2020 12:47:10 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Fabrice Gasnier <fabrice.gasnier@...com>
Cc:     <vilhelm.gray@...il.com>, <alexandre.torgue@...com>,
        <mcoquelin.stm32@...il.com>, <benjamin.gaignard@...com>,
        <linux-iio@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] counter: stm32-timer-cnt: remove iio headers

On Tue, 11 Feb 2020 11:56:06 +0100
Fabrice Gasnier <fabrice.gasnier@...com> wrote:

> The stm32-timer-cnt driver doesn't use the iio interface. The iio headers
> aren't relevant and can be removed as reported by William in [1].
> With this change, mod_devicetable.h needs to be added to define the
> 'of_device_id' struct.
> 
> [1] https://lkml.org/lkml/2020/2/10/1516
> 
> Reported-by: William Breathitt Gray <vilhelm.gray@...il.com>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...com>
Applied.

thanks,

Jonathan

> ---
> Note this applies on top of:
> - "counter: stm32-timer-cnt: add power management support"
> ---
>  drivers/counter/stm32-timer-cnt.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c
> index 50496f4..ef2a974 100644
> --- a/drivers/counter/stm32-timer-cnt.c
> +++ b/drivers/counter/stm32-timer-cnt.c
> @@ -8,9 +8,8 @@
>   *
>   */
>  #include <linux/counter.h>
> -#include <linux/iio/iio.h>
> -#include <linux/iio/types.h>
>  #include <linux/mfd/stm32-timers.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/pinctrl/consumer.h>
>  #include <linux/platform_device.h>