linux-kernel - Re: [PATCH 06/18] m68k: Replace setup_irq() by request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200214130710.GA5675@afzalpc>
Date:   Fri, 14 Feb 2020 18:37:10 +0530
From:   afzal mohammed <afzal.mohd.ma@...il.com>
To:     Greg Ungerer <gerg@...ux-m68k.org>
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Julia Lawall <Julia.Lawall@...6.fr>
Subject: Re: [PATCH 06/18] m68k: Replace setup_irq() by request_irq()

Hi Greg,

On Thu, Feb 13, 2020 at 05:11:17PM +1000, Greg Ungerer wrote:
> On 12/2/20 6:03 pm, afzal mohammed wrote:

> > diff --git a/arch/m68k/68000/timers.c b/arch/m68k/68000/timers.c
> > index 71ddb4c98726..7a55d664592e 100644
> > --- a/arch/m68k/68000/timers.c
> > +++ b/arch/m68k/68000/timers.c
> > @@ -68,12 +68,6 @@ static irqreturn_t hw_tick(int irq, void *dummy)
> >   /***************************************************************************/
> > -static struct irqaction m68328_timer_irq = {
> > -	.name	 = "timer",
> > -	.flags	 = IRQF_TIMER,
> > -	.handler = hw_tick,
> > -};
> > -
> >   /***************************************************************************/

> Remove this comment line as well. Nothing left to separate
> between those comment lines with the struct initialization removed.

i will remove above as well as the similar ones.

Because  you mentioned, i checked cocci o/p (change above was provided
as is by running cocci). Cocci by default removes the comment line you
mentioned. Initially that was the way cocci was run, but then it was
observed that in another file in addition to removing associated
comments, it was swallowing other unrelated comments that were living
together. Also sometimes associated comments had to be retained, just
that it had to be relocated near added code (that is not applicable in
this case). So i ran cocci w/ "--keep-comments" option & decided to
manually handle comment related, in this file i failed noticing the
unneeded comment line during self review.

> I tested this out on ColdFire hardware I have, worked fine.
> All defconfigs still compiled too.

Thanks for testing

Regards
afzal