linux-kernel - Re: [RFC PATCH 1/2] Input: add `SW_MACHINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40ab03bb-4746-4414-f4e2-60740d539f3e@wizzup.org>
Date:   Sat, 15 Feb 2020 10:09:22 +0100
From:   Merlijn Wajer <merlijn@...zup.org>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Mattias Jacobsson <2pi@....nu>,
        "Darren Hart (VMware)" <dvhart@...radead.org>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [RFC PATCH 1/2] Input: add `SW_MACHINE_COVER`

Hi Sebastian,

On 14/02/2020 15:38, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Feb 14, 2020 at 02:02:47PM +0100, Merlijn Wajer wrote:
>> This event code represents the state of a removable cover of a device.
>> Value 1 means that the cover is open or removed, value 0 means that the
>> cover is closed.
> 
> This is the opposit of what is being stated everywhere else. It does
> not really matter, but it must be used consistently :)

Oh, my bad. Indeed, value 1 means that the cover is closed, will fix.

>> This can be used to preempt users removing a removable mmc card or even
>> the battery, allowing userspace to attempt to safely unmount a card.
> 
> I would drop this sentence, since its very specific to the N900. The
> name is generic enough to e.g. also apply for desktop machines, which
> sometimes have a cover switch for doing a shutdown (because of poor
> airflow when open).

Fair enough.

>> ---
> 
> Missing Signed-off-by. 

Will add - thanks.

> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Cheers,
Merlijn



Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)