linux-kernel - Re: [RFC PATCH 2/2] ARM: dts: n900: remove mmc1 card detect gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 15 Feb 2020 10:13:35 +0100
From:   Merlijn Wajer <merlijn@...zup.org>
To:     Sebastian Reichel <sre@...nel.org>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Mattias Jacobsson <2pi@....nu>,
        "Darren Hart (VMware)" <dvhart@...radead.org>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [RFC PATCH 2/2] ARM: dts: n900: remove mmc1 card detect gpio

Hi,

On 14/02/2020 15:49, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Feb 14, 2020 at 02:02:48PM +0100, Merlijn Wajer wrote:
>> Instead, expose the key via the input framework, as SW_MACHINE_COVER
> 
> How about:
> 
> The chip-detect GPIO is actually detecting if the cover is closed.
> Technically it's possible to use the SD card with open cover. The
> only downside is risk of battery falling out and user being able
> to physically remove the card.
> 
> The behaviour of SD card not being available when the device is
> open is unexpected and creates more problems than it solves. There
> is a high chance, that more people accidently break their rootfs
> by opening the case without physically removing the card.

Sounds good.

> Missing SoB.

Will add.

> Patch itself is
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Thanks.

Cheers,
Merlijn



Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)