lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Feb 2020 14:03:47 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Alexandre Belloni <alexandre.belloni@...tlin.com>, "David S. Miller" <davem@...emloft.net>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Antoine Ténart <antoine.tenart@...tlin.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH net] net: macb: Properly handle phylink on at91rm9200 On 2/17/2020 2:43 AM, Alexandre Belloni wrote: > at91ether_init was handling the phy mode and speed but since the switch to > phylink, the NCFGR register got overwritten by macb_mac_config(). > > Add new phylink callbacks to handle emac and at91rm9200 properly. > > Fixes: 7897b071ac3b ("net: macb: convert to phylink") > Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com> > --- [snip] > +static void at91ether_mac_link_up(struct phylink_config *config, > + unsigned int mode, > + phy_interface_t interface, > + struct phy_device *phy) > +{ > + struct net_device *ndev = to_net_dev(config->dev); > + struct macb *bp = netdev_priv(ndev); > + > + /* Enable Rx and Tx */ > + macb_writel(bp, NCR, macb_readl(bp, NCR) | MACB_BIT(RE) | MACB_BIT(TE)); > + > + netif_tx_wake_all_queues(ndev); So this happens to be copied from the mvpp2 driver, if this is a requirement, should not this be moved to the phylink implementation since it already manages the carrier? Those two drivers are the only ones doing this. -- Florian
Powered by blists - more mailing lists