linux-kernel - Re: [PATCH net] net: macb: Properly handle phylink on at91rm9200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Feb 2020 18:47:11 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Antoine Ténart <antoine.tenart@...tlin.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net] net: macb: Properly handle phylink on at91rm9200

On Mon, Feb 17, 2020 at 06:42:44PM +0100, Alexandre Belloni wrote:
> On 17/02/2020 16:56:44+0000, Russell King - ARM Linux admin wrote:
> > On Mon, Feb 17, 2020 at 11:43:48AM +0100, Alexandre Belloni wrote:
> > > at91ether_init was handling the phy mode and speed but since the switch to
> > > phylink, the NCFGR register got overwritten by macb_mac_config().
> > 
> > I don't think this actually explains anything - or at least I can't
> > make sense of it with respect to your patch.
> > 
> > You claim that the NCFGR register gets overwritten in macb_mac_config(),
> > but I see that the NCFGR register is read-modify-write in there,
> > whereas your new implementation below doesn't bother reading the
> > present value.
> > 
> > I think the issue you're referring to is the clearing of the PAE bit,
> > which is also the RM9200_RMII for at91rm9200?
> > 
> 
> This is the issue, I'll rework the commit message.

Thanks.

> > Next, there's some duplication of code introduced here - it seems
> > that the tail end of macb_mac_link_down() and at91ether_mac_link_down()
> > are identical, as are the tail end of macb_mac_link_up() and
> > at91ether_mac_link_up().
> > 
> 
> I was split between having a new phylink_mac_ops instance or
> differentiating in the various callbacks. If your preference is the
> latter, I'm fine with that.

I haven't thought too much about what the code would look like after
the phylink changes - I spent quite some time working out what the
differences were between what is already in mainline and what your
patch was adding back.

As far as I'm concerned, however, any of the MAC drivers I've converted
that I don't have the hardware for (which includes this driver) are
merely illustrative patches that show the kind of thing I'm after
there - and only become "real" patches once they're tested.

> > > Add new phylink callbacks to handle emac and at91rm9200 properly.
> > > 
> > > Fixes: 7897b071ac3b ("net: macb: convert to phylink")
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
> > > ---
> > 
> > I posted a heads-up message last week about updates to phylink that
> > I'll be submitting soon (most of the prerequisits have now been sent
> > for review) which touch every phylink_mac_ops-using piece of code in
> > the tree.  Unfortunately, this patch introduces a new instance that
> > likely isn't going to get my attention, so it's going to create a
> > subtle merge conflict between net-next and net trees unless we work
> > out some way to deal with it.
> > 
> > I'm just mentioning that so that some thought can be applied now
> > rather than when it actually happens - especially as I've no way to
> > test the changes that will be necessary for this driver.
> > 
> 
> Does that help if I change the callbacks instead of adding a new
> phylink_mac_ops instance? I can also wait for your work and rebase on
> top of that but that would mean that the fix will not get backported.

Obviously, the phylink conversion for this driver caused a regression
that should be fixed, so I think it's right to fix it in whatever way
you think would be most suitable.  We just need to consider how to
deal with the conflicts that are going to occur between net and
net-next.

One option would be to let davem know about the impending conflict,
and with your patch merged into net, if he can then merge the net
tree into net-next before applying my series - with an updated macb
conversion patch from you (tested would be good!) - then everything
should work out fine.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up