linux-kernel - Re: [PATCH] um: vector: Avoid NULL ptr deference if transport is unset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74c04f11-4b67-d1a7-7d05-197a229b245c@cambridgegreys.com>
Date:   Mon, 17 Feb 2020 07:53:50 +0000
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
        linux-um@...ts.infradead.org
Cc:     Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] um: vector: Avoid NULL ptr deference if transport is
 unset

On 16/02/2020 21:36, Sjoerd Simons wrote:
> When the transport option of a vec isn't set strncmp ends up being
> called on a NULL pointer. Better not do that.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@...labora.co.uk>
> 
> ---
> 
>   arch/um/drivers/vector_kern.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> index 0ff86391f77d..ca90666c0b61 100644
> --- a/arch/um/drivers/vector_kern.c
> +++ b/arch/um/drivers/vector_kern.c
> @@ -198,6 +198,9 @@ static int get_transport_options(struct arglist *def)
>   	long parsed;
>   	int result = 0;
>   
> +	if (transport == NULL)
> +		return -EINVAL;
> +
>   	if (vector != NULL) {
>   		if (kstrtoul(vector, 10, &parsed) == 0) {
>   			if (parsed == 0) {
> 
Acked-By: Anton Ivanov <anton.ivanov@...bridgegreys.com>

-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/