linux-kernel - Re: [PATCH] um: vector: Avoid NULL ptr deference if transport is unset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 29 Mar 2020 23:55:47 +0200
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Anton Ivanov <anton.ivanov@...bridgegreys.com>
Cc:     Sjoerd Simons <sjoerd.simons@...labora.co.uk>,
        linux-um <linux-um@...ts.infradead.org>,
        Richard Weinberger <richard@....at>,
        Jeff Dike <jdike@...toit.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] um: vector: Avoid NULL ptr deference if transport is unset

On Mon, Feb 17, 2020 at 8:54 AM Anton Ivanov
<anton.ivanov@...bridgegreys.com> wrote:
>
> On 16/02/2020 21:36, Sjoerd Simons wrote:
> > When the transport option of a vec isn't set strncmp ends up being
> > called on a NULL pointer. Better not do that.
> >
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@...labora.co.uk>
> >
> > ---
> >
> >   arch/um/drivers/vector_kern.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
> > index 0ff86391f77d..ca90666c0b61 100644
> > --- a/arch/um/drivers/vector_kern.c
> > +++ b/arch/um/drivers/vector_kern.c
> > @@ -198,6 +198,9 @@ static int get_transport_options(struct arglist *def)
> >       long parsed;
> >       int result = 0;
> >
> > +     if (transport == NULL)
> > +             return -EINVAL;
> > +
> >       if (vector != NULL) {
> >               if (kstrtoul(vector, 10, &parsed) == 0) {
> >                       if (parsed == 0) {
> >
> Acked-By: Anton Ivanov <anton.ivanov@...bridgegreys.com>

Applied, thanks!

-- 
Thanks,
//richard