lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Feb 2020 09:37:25 +0100 From: David Hildenbrand <david@...hat.com> To: Nathan Chancellor <natechancellor@...il.com>, "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com> Cc: virtualization@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com Subject: Re: [PATCH] virtio_balloon: Adjust label in virtballoon_probe On 16.02.20 01:40, Nathan Chancellor wrote: > Clang warns when CONFIG_BALLOON_COMPACTION is unset: > > ../drivers/virtio/virtio_balloon.c:963:1: warning: unused label > 'out_del_vqs' [-Wunused-label] > out_del_vqs: > ^~~~~~~~~~~~ > 1 warning generated. > > Move the label within the preprocessor block since it is only used when > CONFIG_BALLOON_COMPACTION is set. > > Fixes: 1ad6f58ea936 ("virtio_balloon: Fix memory leaks on errors in virtballoon_probe()") > Link: https://github.com/ClangBuiltLinux/linux/issues/886 > Signed-off-by: Nathan Chancellor <natechancellor@...il.com> > --- > drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index 7bfe365d9372..341458fd95ca 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -959,8 +959,8 @@ static int virtballoon_probe(struct virtio_device *vdev) > iput(vb->vb_dev_info.inode); > out_kern_unmount: > kern_unmount(balloon_mnt); > -#endif > out_del_vqs: > +#endif > vdev->config->del_vqs(vdev); > out_free_vb: > kfree(vb); > Reviewed-by: David Hildenbrand <david@...hat.com> -- Thanks, David / dhildenb
Powered by blists - more mailing lists