linux-kernel - Re: [PATCH 1/1] efi/libstub: simplify efi_get_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Feb 2020 09:37:46 +0100
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Heinrich Schuchardt <xypron.glpk@....de>
Cc:     linux-efi <linux-efi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] efi/libstub: simplify efi_get_memory_map()

On Sun, 16 Feb 2020 at 19:40, Heinrich Schuchardt <xypron.glpk@....de> wrote:
>
> Do not check the value of status twice.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@....de>

Thanks, I'll queue this one as well.

> ---
>  drivers/firmware/efi/libstub/mem.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/mem.c b/drivers/firmware/efi/libstub/mem.c
> index c6a784ed640f..c25fd9174b74 100644
> --- a/drivers/firmware/efi/libstub/mem.c
> +++ b/drivers/firmware/efi/libstub/mem.c
> @@ -52,13 +52,14 @@ efi_status_t efi_get_memory_map(struct efi_boot_memmap *map)
>                 goto again;
>         }
>
> -       if (status != EFI_SUCCESS)
> +       if (status == EFI_SUCCESS) {
> +               if (map->key_ptr)
> +                       *map->key_ptr = key;
> +               if (map->desc_ver)
> +                       *map->desc_ver = desc_version;
> +       } else {
>                 efi_bs_call(free_pool, m);
> -
> -       if (map->key_ptr && status == EFI_SUCCESS)
> -               *map->key_ptr = key;
> -       if (map->desc_ver && status == EFI_SUCCESS)
> -               *map->desc_ver = desc_version;
> +       }
>
>  fail:
>         *map->map = m;
> --
> 2.25.0
>