linux-kernel - Re: [PATCH v2 3/3] io_uring: add splice(2) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d803558-ab09-1850-2c38-38848b8ddf27@samba.org>
Date:   Mon, 17 Feb 2020 16:18:03 +0100
From:   Stefan Metzmacher <metze@...ba.org>
To:     Pavel Begunkov <asml.silence@...il.com>,
        Jens Axboe <axboe@...nel.dk>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        io-uring@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] io_uring: add splice(2) support

Hi Pavel,

> +static int io_splice_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
> +{
> +	struct io_splice* sp = &req->splice;
> +	unsigned int valid_flags = SPLICE_F_FD_IN_FIXED | SPLICE_F_ALL;
> +	int ret;
> +
> +	if (req->flags & REQ_F_NEED_CLEANUP)
> +		return 0;
> +
> +	sp->file_in = NULL;
> +	sp->off_in = READ_ONCE(sqe->off_in);
> +	sp->off_out = READ_ONCE(sqe->off);
> +	sp->len = READ_ONCE(sqe->len);
> +	sp->flags = READ_ONCE(sqe->splice_flags);
> +
> +	if (unlikely(READ_ONCE(sqe->ioprio) || (sp->flags & ~valid_flags)))
> +		return -EINVAL;

Why is ioprio not supported?

metze



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)