linux-kernel - Re: [PATCH 2/4] mtd: rawnand: cadence: fix calculating avaialble oob size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200218114537.723436b3@xps13>
Date:   Tue, 18 Feb 2020 11:45:53 +0100
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Piotr Sroka <piotrs@...ence.com>
Cc:     Kazuhiro Kasai <kasai.kazuhiro@...ionext.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Brian Norris <computersforpeace@...il.com>,
        Marek Vasut <marek.vasut@...il.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        <linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/4] mtd: rawnand: cadence: fix calculating avaialble
 oob size

Hi Piotr,

Piotr Sroka <piotrs@...ence.com> wrote on Mon, 10 Feb 2020 10:55:26
+0100:

There is a typo in the title (available).

> Previously ecc_sector size was used for calculation but its value
> was not yet known.

Can we rework a little bit this? What about:

	The value of cdns_chip->sector_count is not known at the moment
	of the derivation of ecc_size, leading to a zero value. Fix
	this by assigning ecc_size later in the code.

Also, I think it deserves a Fixes/Cc:stable tag!

> 
> Signed-off-by: Piotr Sroka <piotrs@...ence.com>
> ---
>  drivers/mtd/nand/raw/cadence-nand-controller.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
> index 5063a8b493a4..2ebfd0934739 100644
> --- a/drivers/mtd/nand/raw/cadence-nand-controller.c
> +++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
> @@ -2595,7 +2595,7 @@ int cadence_nand_attach_chip(struct nand_chip *chip)
>  {
>  	struct cdns_nand_ctrl *cdns_ctrl = to_cdns_nand_ctrl(chip->controller);
>  	struct cdns_nand_chip *cdns_chip = to_cdns_nand_chip(chip);
> -	u32 ecc_size = cdns_chip->sector_count * chip->ecc.bytes;
> +	u32 ecc_size;
>  	struct mtd_info *mtd = nand_to_mtd(chip);
>  	int ret;
>  
> @@ -2634,6 +2634,7 @@ int cadence_nand_attach_chip(struct nand_chip *chip)
>  	/* Error correction configuration. */
>  	cdns_chip->sector_size = chip->ecc.size;
>  	cdns_chip->sector_count = mtd->writesize / cdns_chip->sector_size;
> +	ecc_size = cdns_chip->sector_count * chip->ecc.bytes;
>  
>  	cdns_chip->avail_oob_size = mtd->oobsize - ecc_size;
>  

Thanks,
Miquèl