linux-kernel - Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200218114902.GA259088@lenoch>
Date:   Tue, 18 Feb 2020 12:49:02 +0100
From:   Ladislav Michl <ladis@...ux-mips.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     MyungJoo Ham <myungjoo.ham@...sung.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org,
        kernel@...a-handheld.com, linux-omap@...r.kernel.org
Subject: Re: [PATCH v3] extcon: palmas: hide error messages if gpio returns
 -EPROBE_DEFER

Hi Nikolaus,

On Mon, Feb 17, 2020 at 09:25:32PM +0100, H. Nikolaus Schaller wrote:
> > The rest of discussion
> > would need disassembly and I'll do it once I'll be waiting for yet another
> > long run recompile.
> 
> :)

Just FYI, original compiled with gcc-8.2.1:
   text    data     bss     dec     hex filename
   4358     104       0    4462    116e drivers/extcon/extcon-palmas.o

Your patch:
   text    data     bss     dec     hex filename
   4382     104       0    4486    1186 drivers/extcon/extcon-palmas.o

My patch with printing error value:
   text	   data	    bss	    dec	    hex	filename
   4406	    104	      0	   4510	   119e	drivers/extcon/extcon-palmas.o

So even without disassembling numbers speak for themselves :)

	l.