linux-kernel - Re: [PATCH V4 3/3] dt-bindings: geni-se: Add binding for UART pin swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Feb 2020 11:07:31 -0800
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Akash Asthana <akashast@...eaurora.org>
Cc:     robh+dt@...nel.org, agross@...nel.org, mark.rutland@....com,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, mgautam@...eaurora.org,
        rojay@...eaurora.org, skakit@...eaurora.org, swboyd@...omium.org
Subject: Re: [PATCH V4 3/3] dt-bindings: geni-se: Add binding for UART pin
 swap

Hi Akash,

I didn't see a patch that implements the binding, did you post it?


On Mon, Feb 17, 2020 at 03:06:52PM +0530, Akash Asthana wrote:
> Add documentation to support RX/TX/CTS/RTS pin swap in HW.
> 
> Signed-off-by: Akash Asthana <akashast@...eaurora.org>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> index 11530df..7e4b9af 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml
> @@ -165,6 +165,15 @@ patternProperties:
>            - description: UART core irq
>            - description: Wakeup irq (RX GPIO)
>  
> +      rx-tx-swap:
> +        description: RX and TX pins are swap.

s/swap/swapped/

> +
> +      cts-rts-swap:
> +        description: CTS and RTS pins are swap.

s/swap/swapped/

> +
> +      rx-tx-cts-rts-swap:
> +        description: RX-TX and CTS-RTS both pairs are swap.

I don't think this option adds much value, if both pairs are swapped
the above two properties can be set.

> +
>      required:
>        - compatible
>        - interrupts
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project