linux-kernel - RE: bnx2x: Latest firmware requirement breaks no regression policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN2PR18MB2528C681601B34D05100DF89D3100@MN2PR18MB2528.namprd18.prod.outlook.com>
Date:   Wed, 19 Feb 2020 08:49:33 +0000
From:   Sudarsana Reddy Kalluru <skalluru@...vell.com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>,
        Ariel Elior <aelior@...vell.com>,
        GR-everest-linux-l2 <GR-everest-linux-l2@...vell.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "it+linux-netdev@...gen.mpg.de" <it+linux-netdev@...gen.mpg.de>
Subject: RE: bnx2x: Latest firmware requirement breaks no regression policy

Hi Paul,
    The firmware file referred below (i.e., storm FW) should be present on the host (i.e., /lib/firmware/bnx2x/ path), not the device. Driver must require this version of the FW to initialize the device, and hence provide the network functionality. Also, the driver is not backward compatible with older FW versions.
So it's not possible to handle the below error scenario in the driver,
	>     bnx2x 0000:41:00.0: Direct firmware load for bnx2x/bnx2x-e1h-7.13.11.0.fw failed with error -2
	>     bnx2x: [bnx2x_init_firmware:13557(net02)]Can't load firmware file bnx2x/bnx2x-e1h-7.13.11.0.fw
At the most, we can validate the existence of FW file on the host during the kernel build or installation.
FW image name from driver sources:
	drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c:
	#define FW_FILE_NAME_E1         "bnx2x/bnx2x-e1-" FW_FILE_VERSION ".fw"
	#define FW_FILE_NAME_E1H        "bnx2x/bnx2x-e1h-" FW_FILE_VERSION ".fw"
	#define FW_FILE_NAME_E2         "bnx2x/bnx2x-e2-" FW_FILE_VERSION ".fw"
FW image path on the host:
	/lib/firmware/bnx2x/bnx2x-e1h-7.13.11.0.fw

Thanks,
Sudarsana
> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> Behalf Of Paul Menzel
> Sent: Monday, February 17, 2020 6:48 PM
> To: Ariel Elior <aelior@...vell.com>; Sudarsana Reddy Kalluru
> <skalluru@...vell.com>; GR-everest-linux-l2 <GR-everest-linux-
> l2@...vell.com>
> Cc: netdev@...r.kernel.org; LKML <linux-kernel@...r.kernel.org>; it+linux-
> netdev@...gen.mpg.de
> Subject: bnx2x: Latest firmware requirement breaks no regression policy
> 
> Dear Linux folks,
> 
> 
> Updating a server from 4.19.x to 5.4.x, the network device
> 
>     Ethernet controller [0200]: Broadcom Inc. and subsidiaries NetXtreme II
> BCM57711 10-Gigabit PCIe [14e4:164f]
> 
> failed to initialize due to missing firmware.
> 
>     bnx2x 0000:41:00.0: Direct firmware load for bnx2x/bnx2x-e1h-7.13.11.0.fw
> failed with error -2
>     bnx2x: [bnx2x_init_firmware:13557(net02)]Can't load firmware file
> bnx2x/bnx2x-e1h-7.13.11.0.fw
>     bnx2x: [bnx2x_func_hw_init:6002(net02)]Error loading firmware
>     bnx2x: [bnx2x_nic_load:2730(net02)]HW init failed, aborting
> 
> That is undesired, because without network access one has to have
> direct system access to find out what is wrong.
> 
> Could you please change the policy to only print a big warning,
> if the latest firmware is not available, and an update suggestion?
> 
> 
> Kind regards,
> 
> Paul