linux-kernel - Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <319a0922-3de2-5d02-65c3-d96036eea6d9@nvidia.com>
Date:   Wed, 19 Feb 2020 21:40:09 +0530
From:   Sameer Pujar <spujar@...dia.com>
To:     Dmitry Osipenko <digetx@...il.com>,
        Jon Hunter <jonathanh@...dia.com>
CC:     <spujar@...dia.com>, <devicetree@...r.kernel.org>,
        <alsa-devel@...a-project.org>, <lgirdwood@...il.com>,
        <linux-kernel@...r.kernel.org>, <broonie@...nel.org>,
        <atalambedu@...dia.com>, <tiwai@...e.com>, <viswanathl@...dia.com>,
        <linux-tegra@...r.kernel.org>, <robh+dt@...nel.org>,
        <thierry.reding@...il.com>, <sharadg@...dia.com>,
        <rlokhande@...dia.com>, <mkumard@...dia.com>, <dramesh@...dia.com>
Subject: Re: [alsa-devel] [PATCH 4/9] ASoC: tegra: add Tegra210 based I2S
 driver



On 2/18/2020 6:30 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> 14.02.2020 17:05, Jon Hunter пишет:
>> On 29/01/2020 03:41, Dmitry Osipenko wrote:
>>
>> ...
>>
>>> The !RPM case isn't supported by Tegra anymore in upstream kernel. I'm
>>> trying to help to make yours driver better and gave you reasons to
>>> remove the unneeded code, while you're keep saying that "there is no
>>> harm to retain it", which is not a reason to clutter up the code. I
>>> don't feel that it's worthwhile to continue arguing here.
>> On further review, it does look like a reasonable argument to get rid of
>> this now completely. Like you see less clutter and the soc-core should
>> ensure that the card is shutdown before unloading. OK, so fine with me.
> And the RPM core ensures that state is synced on disable, sorry if I
> didn't make it clear before.
>
> +1 for less clutter :)

Done, I am removing explicit RPM suspend in the next revision. Thanks 
Dmitry and Jon.