[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200221083459.5469ae4bbb26b57f2063ec99@kernel.org>
Date: Fri, 21 Feb 2020 08:34:59 +0900
From: Masami Hiramatsu <mhiramat@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: Geert Uytterhoeven <geert@...ux-m68k.org>,
Borislav Petkov <bp@...en8.de>,
LKML <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v2 4/8] bootconfig: Remove unneeded checksum
On Thu, 20 Feb 2020 12:14:31 -0500
Steven Rostedt <rostedt@...dmis.org> wrote:
> On Thu, 20 Feb 2020 21:19:02 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
>
> > Remove checksum of bootconfig because we already use a magic
> > word to identify bootconfig. This checksum was used for
> > checking whether there is a bootconfig at the end of initrd
> > or not. Since we have a bootconfig magic word to identify
> > the bootconfig data, we do not this checksum anymore.
> >
> > Thus the block image of the initrd file with bootconfig is
> > as follows.
> >
> > [initrd][bootconfig][size(u32)][#BOOTCONFIG\n]
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> > ---
> >
>
> Hmm, I think the checksum is still good to have, in case of a corrupted
> file. Does it hurt to keep it?
No problem. We can drop this patch.
I thought this check was a bit redundant since (originally) this was
introduced to identify the bootconfig.
Thank you,
>
> -- Steve
--
Masami Hiramatsu <mhiramat@...nel.org>
Powered by blists - more mailing lists