linux-kernel - Re: [PATCH v2 6/8] bootconfig: Overwrite value on same key by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200220121641.6c0d611a@gandalf.local.home>
Date:   Thu, 20 Feb 2020 12:16:41 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Borislav Petkov <bp@...en8.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH v2 6/8] bootconfig: Overwrite value on same key by
 default

On Thu, 20 Feb 2020 21:19:22 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> Currently, bootconfig does not overwrite existing value
> on same key, but add new value to the tail of an array.
> But this looks a bit confusing because similar syntax
> configuration always overwrite the value by default.

Should we even allow this case? Or at the very least, some output
should be made that a value is being overwritten.

-- Steve


> 
> This changes the behavior to overwrite value on same key.
> 
> For example, if there are 2 entries
> 
>   key = value
>   ...
>   key = value2
> 
> Then, the key is updated as below.
> 
>   key = value2
> 
> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>